reed Comments

thanks for the hint (via it only working for deno test) this gave me the confidence to look into rust for the first time. i eventually got it working. this was significantly complicated by the way i was writing my test in typescript: i wasn't properly shutting down the server from Deno.serve, which prevented anything after this block

        .worker
        .run_event_loop(maybe_coverage_collector.is_none())
        .await?;

        .worker
        .run_event_loop(maybe_coverage_collector.is_none())
        .await?;

from finishing (e.g. collecting coverage in the worker). after rearranging the tests (which allowed the worker to properly exit), then my first rust changed showed its effect <:party_deno:1035517691517218847> basically: serverProcess.kill("SIGTERM"); on the spawned subprocess is somehow too aggressive. instead of doing that after the test ends, i changed the way i launch the server to:

const ac = new AbortController();
start(manifest, {
  signal: ac.signal,
});
setTimeout(() => ac.abort(), 10000);

const ac = new AbortController();
start(manifest, {
  signal: ac.signal,
});
setTimeout(() => ac.abort(), 10000);

this has the downside of the test needing to finish in 10 seconds, but it at least allowed the coverage to complete. any explanation for this is appreciated. i will create a PR in the next few days for "allow DENO_UNSTABLE_COVERAGE_DIR in run subcommand"

11 replies

DDeno

•Created by iunoblue on 7/20/2023 in #help

Docs on understanding how Fresh works under the hood.

I was in the same boat a month ago. Since then I mostly get it, and explanations of the following parts of fresh (in no particular order) would probably help others out: - Rendering - Building - Server Initialization - Routing - Plugins - Hydration - (De)serialization I guess I'm missing a part or two

9 replies

DDeno

•Created by reed on 7/19/2023 in #help

Coverage with subprocess

{ args: ["run", "-A", "--unstable", name], env: { "DENO_UNSTABLE_COVERAGE_DIR": "cov", }, } is what i'm doing 🤷‍♂️

11 replies

DDeno

•Created by reed on 7/19/2023 in #help

Coverage with subprocess

And this should be set in the env property of the Deno.CommandOptions object I have? I tried this and I still couldn't generate coverage for my subprocess

11 replies

DDeno

•Created by karolskolasinski on 7/19/2023 in #help

How to exclude folder from deno lint

https://deno.land/manual@v1.35.1/getting_started/configuration_file#lint Not sure about webstorm, but the exclude option does exist

3 replies