bennyp Comments

bennyp

Posts Comments

DDeno

•Created by KyleJune on 5/4/2025 in #help

Coverage for child processes

@kt3k is it possible that your PR adding automatic coverage doesn't propagate the necessary env to child processes?

10 replies

DDeno

•Created by KyleJune on 5/4/2025 in #help

Coverage for child processes

2.3 turns on coverage for the deno test command, maybe they don't also propagate that env var?

10 replies

DDeno

•Created by KyleJune on 5/4/2025 in #help

Coverage for child processes

https://github.com/denoland/deno/issues/7648 this seems to indicate that coverage should work

10 replies

DDeno

•Created by KyleJune on 5/4/2025 in #help

Coverage for child processes

have you opened an issue for this?

10 replies

DDeno

•Created by bennyp on 4/20/2025 in #help

Using scopes in deno.json to mock modules for tests

I solved this by passing context param into my functions - more testable that way

2 replies

DDeno

•Created by bennyp on 4/17/2025 in #help

deno compile --include whatev.wasm

Basically I'm trying to get the old wasm importing behaviour, without all the static analysis:

import { Parser, Language, Query } from "web-tree-sitter";
import { readAll } from 'jsr:@std/io/read-all';

const f = await Deno.open("./tree-sitter/tree-sitter-css.wasm")
const grammar = await readAll(f);

await Parser.init();
const parser = new Parser();
const Css = await Language.load(grammar);
parser.setLanguage(Css);

import { Parser, Language, Query } from "web-tree-sitter";
import { readAll } from 'jsr:@std/io/read-all';

const f = await Deno.open("./tree-sitter/tree-sitter-css.wasm")
const grammar = await readAll(f);

await Parser.init();
const parser = new Parser();
const Css = await Language.load(grammar);
parser.setLanguage(Css);

2 replies

DDeno

•Created by bennyp on 4/16/2025 in #help

Writing the whole buffer to stdout

solved: https://stackoverflow.com/a/79576657/2515275

3 replies

DDeno

•Created by bennyp on 4/16/2025 in #help

Writing the whole buffer to stdout

Inspecting the above error message, it seems clear that data is being lost here. A correct response should look like:

Content-Length: 48

{"jsonrpc": 2.0, "id": 13, "result": ["...etc"]}

Content-Length: 48

{"jsonrpc": 2.0, "id": 13, "result": ["...etc"]}

3 replies

DDeno

•Created by bennyp on 4/3/2025 in #help

Bundling node-tree-sitter

We've got https://deno.land/x/deno_tree_sitter@0.2.8.5 BUT

✘ [ERROR] Relative import path "fs" not prefixed with / or ./ or ../ and not in import map from "https://deno.land/x/deno_tree_sitter@0.2.8.5/tree_sitter.js" [plugin deno-resolver]

    https://deno.land/x/deno_tree_sitter@0.2.8.5/tree_sitter.js:2075:36:
      2075 │                     let r = require("fs")
           ╵                                     ~~~~

✘ [ERROR] Relative import path "fs" not prefixed with / or ./ or ../ and not in import map from "https://deno.land/x/deno_tree_sitter@0.2.8.5/tree_sitter.js" [plugin deno-resolver]

    https://deno.land/x/deno_tree_sitter@0.2.8.5/tree_sitter.js:2075:36:
      2075 │                     let r = require("fs")
           ╵                                     ~~~~

3 replies

DDeno

•Created by bennyp on 4/3/2025 in #help

Bundling node-tree-sitter

with this esbuild call, I can run compile to completion

await esbuild.build({
  plugins: [...denoPlugins()],
  loader: {
    ".node": "copy"
  },
  entryPoints: ['src/main.ts'],
  outfile: './dist/main.js',
  bundle: true,
  format: 'esm',
});

await esbuild.build({
  plugins: [...denoPlugins()],
  loader: {
    ".node": "copy"
  },
  entryPoints: ['src/main.ts'],
  outfile: './dist/main.js',
  bundle: true,
  format: 'esm',
});

however:

Language server error: design-tokens-language-server

oneshot canceled
-- stderr--
error: Uncaught (in promise) Error: Dynamic require of "fs" is not supported
  throw Error('Dynamic require of "' + x + '" is not supported');
        ^
    at file:///tmp/deno-compile-design-tokens-language-server/main.js:11:9
    at node_modules/.deno/node-gyp-build@4.8.4/node_modules/node-gyp-build/node-gyp-build.js (file:///tmp/deno-compile-design-tokens-language-server/main.js:6092:15)
    at __require3 (file:///tmp/deno-compile-design-tokens-language-server/main.js:22:50)
    at node_modules/.deno/node-gyp-build@4.8.4/node_modules/node-gyp-build/index.js (file:///tmp/deno-compile-design-tokens-language-server/main.js:6265:25)
    at __require3 (file:///tmp/deno-compile-design-tokens-language-server/main.js:22:50)
    at node_modules/.deno/node-tree-sitter@0.0.1/node_modules/node-tree-sitter/index.js (file:///tmp/deno-compile-design-tokens-language-server/main.js:6273:19)
    at __require3 (file:///tmp/deno-compile-design-tokens-language-server/main.js:22:50)
    at file:///tmp/deno-compile-design-tokens-language-server/main.js:31123:34

Language server error: design-tokens-language-server

oneshot canceled
-- stderr--
error: Uncaught (in promise) Error: Dynamic require of "fs" is not supported
  throw Error('Dynamic require of "' + x + '" is not supported');
        ^
    at file:///tmp/deno-compile-design-tokens-language-server/main.js:11:9
    at node_modules/.deno/node-gyp-build@4.8.4/node_modules/node-gyp-build/node-gyp-build.js (file:///tmp/deno-compile-design-tokens-language-server/main.js:6092:15)
    at __require3 (file:///tmp/deno-compile-design-tokens-language-server/main.js:22:50)
    at node_modules/.deno/node-gyp-build@4.8.4/node_modules/node-gyp-build/index.js (file:///tmp/deno-compile-design-tokens-language-server/main.js:6265:25)
    at __require3 (file:///tmp/deno-compile-design-tokens-language-server/main.js:22:50)
    at node_modules/.deno/node-tree-sitter@0.0.1/node_modules/node-tree-sitter/index.js (file:///tmp/deno-compile-design-tokens-language-server/main.js:6273:19)
    at __require3 (file:///tmp/deno-compile-design-tokens-language-server/main.js:22:50)
    at file:///tmp/deno-compile-design-tokens-language-server/main.js:31123:34

3 replies