Node compat for `matchesGlob` from `node:path`?
Hi there ๐
I'm new here but have been a deno fan from the get-go and have several project running on deno deploy v1 and v2 - love it!
I'm using deno 2.5.2 locallyRight now I'm attempting to deploy a tanstack-start app using the Nitro adapter (nightly v3 version) - https://nitro.build/deploy/providers/deno-deploy - https://tanstack.com/start/latest/docs/framework/react/hosting But using that I cant even build and this is the error I get: I've simplified the issue to this code, and I dont really understand why this should not work? terminal output: What am I doing wrong here? Help very much appreciated! ๐๐๐
Deno Deploy - Nitro
Deploy Nitro apps to Deno Deploy.
Hosting | TanStack Start React Docs
Hosting is the process of deploying your application to the internet so that users can access it. This is a critical part of any web development project, ensuring your application is available to the...
7 Replies
I rewrote and expanded your test case a bit so it works in Node (24+) and should work Deno (fails of course as shown above):
Node output:
Deno stays the same:
I'd recommend to open an issue for this.
Interesting, there is -> https://docs.deno.com/api/node/path/~/path.PlatformPath.matchesGlob
But that seems only to exist as a type?
That is interesting! But I think I'll go ahead and open an issue ๐ Thanks!
Of course, that is more than justified. This documentation seems to be automatically generated from the Node types.
GitHub
Node compat: running
matchesGlob from node:path throws ยท Issue...Version: Deno 2.5.2 (and 2.5.4) Deno errors when attempting to run matchesGlob from node:path My use case is attempting to get TanStack Start to run with Deno using the Nitro v2 adapter as describe...
This is now fixed in Deno canary:
damn that was fast ๐ ๐โโ๏ธ :fast_deno:
And now I can build my app using nitro v3 (
npm:nitro-nightly) - absolutely amazed at how quick that got a fix ๐ thanks for the update @fry69!Looking at the code/fix, it was probably a low hanging fruit/oversight.