Deno•16mo ago

deno install not working on latest canary

mac version: Apple M1 Pro
deno version: deno 2.0.0-rc.1+f0a3d20

moonrepoV3 git:(main) ✗ deno upgrade --canary 
Current Deno version: v1.46.3
Looking up canary version

Found latest canary version f0a3d206422af3177e0f36ed22802c1ccc6f7654

Downloading https://dl.deno.land/canary/f0a3d206422af3177e0f36ed22802c1ccc6f7654/deno-aarch64-apple-darwin.zip
Deno is upgrading to version f0a3d206422af3177e0f36ed22802c1ccc6f7654

Upgraded successfully to Deno f0a3d206422af3177e0f36ed22802c1ccc6f7654 (canary)

➜  moonrepoV3 git:(main) ✗ deno install 
error: No such file or directory (os error 2), symlink '../../../../../node_modules/.deno/svelte@4.2.12/node_modules/svelte' -> '/Users/cansoylu/Projects/moonrepoV3/apps/opsap/clients/mobile/node_modules/svelte'

moonrepoV3 git:(main) ✗ deno upgrade --canary 
Current Deno version: v1.46.3
Looking up canary version

Found latest canary version f0a3d206422af3177e0f36ed22802c1ccc6f7654

Downloading https://dl.deno.land/canary/f0a3d206422af3177e0f36ed22802c1ccc6f7654/deno-aarch64-apple-darwin.zip
Deno is upgrading to version f0a3d206422af3177e0f36ed22802c1ccc6f7654

Upgraded successfully to Deno f0a3d206422af3177e0f36ed22802c1ccc6f7654 (canary)

➜  moonrepoV3 git:(main) ✗ deno install 
error: No such file or directory (os error 2), symlink '../../../../../node_modules/.deno/svelte@4.2.12/node_modules/svelte' -> '/Users/cansoylu/Projects/moonrepoV3/apps/opsap/clients/mobile/node_modules/svelte'

you can test this out on github: https://github.com/zemili-group/moonrepoV3

GitHub

GitHub - zemili-group/moonrepoV3: Deno monorepo on deno deploy all ...

Deno monorepo on deno deploy all things zemil-group - zemili-group/moonrepoV3

marvinh.•9/6/24, 4:51 PM

That definitely shouldn't happen. Filed an issue for it https://github.com/denoland/deno/issues/25493

huseyincansoyluOP•9/6/24, 4:55 PM

how can i upgrade to a previous canary release ? where can i find a list of commit hashes ? can you show me the command to run upgrade to spesific commits ?

huseyincansoyluOP•9/6/24, 4:55 PM

thanks so much

huseyincansoyluOP•9/6/24, 4:55 PM

@marvinh.

marvinh.•9/6/24, 4:56 PM

You can find a list of commit hashes on GitHub (those random letters at the right) https://github.com/denoland/deno/commits/main/

You can upgrade to any commit by running

huseyincansoyluOP•9/6/24, 5:04 PM

i am not sure if its correct

Sean Knowles•9/6/24, 5:06 PM

Did this work, it says it didn't find any download after passing in a commit hash?

huseyincansoyluOP•9/6/24, 5:06 PM

yeah i have the same issue @Sean Knowles

Sean Knowles•9/6/24, 5:06 PM

Not sure if we are having any luck here, can't get passed the error @marvinh.

bartlomieju•9/6/24, 6:17 PM

You need to pass the full hash, not the short hash

bartlomieju•9/6/24, 6:17 PM

Click the button next to a hash on GitHub to copy it

bartlomieju•9/6/24, 6:18 PM

I'll improve that error message

SSean Knowles Did this work, it says it didn't find any download after passing in a commit has...

bartlomieju•9/6/24, 6:37 PM

Is there a green checkmark next to that commit on GitHub? If not it will not work

Sean Knowles•9/6/24, 6:37 PM

Okay great thanks will double check that in future

Sean Knowles•9/6/24, 6:37 PM

Thanks

Sean Knowles•9/6/24, 6:39 PM

@bartlomieju Looks like the PR is ready on this? If its merged can we use it on canary immediately?

bartlomieju•9/6/24, 6:40 PM

No, it needs to land on main and you need to wait some time before CI passes. Depending on your os/arch it can be anywhere between 30m and 2h

bartlomieju•9/6/24, 6:40 PM

You can also downgrade to the version before the problematic change for the time being

Sean Knowles•9/6/24, 6:41 PM

I've been trying to...

Sean Knowles•9/6/24, 6:41 PM

No luck!

bartlomieju•9/6/24, 6:42 PM

Have you tried ?

Sean Knowles•9/6/24, 6:42 PM

not yet

Sean Knowles•9/6/24, 6:43 PM

Will try now

bartlomieju•9/6/24, 6:44 PM

@nathanwhit could you please take a look and advise which commit to use?

Sean Knowles•9/6/24, 6:46 PM

didn't work

Sean Knowles•9/6/24, 6:47 PM

Sean Knowles•9/6/24, 6:47 PM

nathanwhit•9/6/24, 6:55 PM

The commit before the bug was introduced is ef1294e4e5beb68676ba64a6c3a44ff0a277e68a, but that's on 1.46.1 so it might be too old if you're already using 2.0 features.

The PR to fix the bug will land whenever CI finishes, and then once CI on main is done the canary with the fix will be available. It'll probably be 1-2 hours from now

Sean Knowles•9/6/24, 7:32 PM

Legendary

Sean Knowles•9/6/24, 7:32 PM

Again, thanks so much for such a quick fix!

Sean Knowles•9/6/24, 7:32 PM

Cheers guys

nathanwhit•9/6/24, 9:30 PM

The fixed canary is now available! If you do you should get the new version. Feel free to try it out and let me know if it works for you now

huseyincansoyluOP•9/7/24, 4:20 PM

It worked! Thanks for the quick fix