mavdotjs•7mo ago

[SOLVED] Unable to publish to JSR via gh action

I am using wasm to build a package, and I am using esbuild to compile the wasm & js into one js file, and I have added a .d.ts file to type the exported functions. when I run deno publish locally, it publishes just fine, yet in my github action, it claims there are slow types and gives "error[missing-explicit-return-type]: missing explicit return type in the public API" error, it only gives me this error for the funcitons I have declared in the .d.ts file.

4 Replies

mavdotjsOP•7mo ago

https://github.com/ts-rex/wasm-bcrypt/actions/runs/9245737017/job/25432481998 logs

GitHub

this is making me insane · ts-rex/wasm-bcrypt@6f41ba2

Rust written wasm bcrypt impl. Contribute to ts-rex/wasm-bcrypt development by creating an account on GitHub.

mavdotjsOP•7mo ago

https://github.com/ts-rex/wasm-bcrypt/blob/master/out/wasm.d.ts

GitHub

wasm-bcrypt/out/wasm.d.ts at master · ts-rex/wasm-bcrypt

Rust written wasm bcrypt impl. Contribute to ts-rex/wasm-bcrypt development by creating an account on GitHub.

mavdotjsOP•7mo ago

omg did I just fix the issue 🤦‍♂️ I put the wrong filename in the esbuild banner

Deno AI Helper•7mo ago

I wasn't able to find the answer to your question in the official Deno documentation. However, based on the information you've provided, it seems like the issue might be related to the TypeScript configuration or the way the types are declared in your .d.ts file. The error message "error[missing-explicit-return-type]: missing explicit return type in the public API" suggests that the TypeScript compiler is expecting an explicit return type on functions that are part of the public API. In TypeScript, it's considered good practice to specify the return type of functions explicitly for better type checking and readability. Here's a quick check you can do: Make sure that all functions in your .d.ts file have an explicit return type. For example:

// Incorrect
function myFunction(param: string);

// Correct
function myFunction(param: string): ReturnType;

// Incorrect
function myFunction(param: string);

// Correct
function myFunction(param: string): ReturnType;

Replace ReturnType with the actual type you expect the function to return. Please note that this advice is not based on the Deno documentation, and I would advise you to double-check the accuracy of the advice given. It's also possible that the TypeScript version or configuration used in your GitHub Actions environment differs from your local setup, which could lead to different behavior. Make sure that your local environment and CI/CD environment are as consistent as possible regarding versions and configurations.

Helpful Links: Why We Added package.json Support to Deno wasmbuild - Using Rust in Deno and Web Apps dnt — the easiest way to publish a hybrid npm module for ESM and CommonJS Types and Type Declarations | Deno Docs Deno 1.7 Release Notes Deno 1.38: HTML doc generator and HMR Deno Deploy Changelog