jaydanurwin
jaydanurwinโ€ข5mo ago

Astro 4.0 Support

Hi there, just wanted to check in if someone from the Deno org could review the PR on the official Deno + Astro adapter? It looks like it's been sitting for a couple of weeks now and is blocking people from using the latest version of Astro. Thank you as always! https://github.com/denoland/deno-astro-adapter/pull/11
GitHub
Astro 4 update and build fix by revgum ยท Pull Request #11 ยท denolan...
The update to Astro 4 and the npm run build seems to work without issue in this update. I see that the npm run test is broken on the main branch and remains broken on this PR. The test/helpers.ts h...
19 Replies
ioB
ioBโ€ข5mo ago
@๐•’๐•ฃ๐•ค๐•™ Not sure if you're the right person to ask for this but I think you do work on Astro?
๐•’๐•ฃ๐•ค๐•™
do you need help with the pr bro my own prs have been waiting for the past 6 months
jaydanurwin
jaydanurwinโ€ข5mo ago
@๐•’๐•ฃ๐•ค๐•™ well that's not great to hear. So I gather Astro and Deno support is an extremely low priority? That's odd given there are blog posts and YT videos about using Astro and Deno together.
jaydanurwin
jaydanurwinโ€ข5mo ago
I was hoping to start using DenoKV and Astro together like this blog post highlights https://deno.com/blog/astro-on-deno
Deno Blog
Build and Ship Astro Sites with Deno and Deno Deploy
Learn how to build and deploy static and server-rendered apps with Astro on Deno and Deno Deploy.
๐•’๐•ฃ๐•ค๐•™
@Kevin Whinnery from deno is in charge of the adapter now
jaydanurwin
jaydanurwinโ€ข5mo ago
Good to know. Well the demo repo itself works but not if you try to update Astro or use their latest integration packages. Seems like a pretty big blocker for someone who wants to use Deno and Astro. Thanks for chiming in @๐•’๐•ฃ๐•ค๐•™!
ioB
ioBโ€ข5mo ago
I guess we're waiting for Kevin then.
๐•’๐•ฃ๐•ค๐•™
it works with the node adapter though
No description
ioB
ioBโ€ข5mo ago
well that's at least good news deno node support has gotten really far
Kevin Whinnery
Kevin Whinneryโ€ข5mo ago
Apologies, the Astro adapter work has not progressed that far. I didnโ€™t realize Node compat could support the Node adapter!
ioB
ioBโ€ข5mo ago
Do you have bandwidth to review/merge PRs?
Kevin Whinnery
Kevin Whinneryโ€ข5mo ago
I can take a look - I had reviewed one a while back that wasnโ€™t fully working, but can take a look again for new ones
๐•’๐•ฃ๐•ค๐•™
which one was it?
jaydanurwin
jaydanurwinโ€ข5mo ago
Ya it seems like this should be a little higher priority @Kevin Whinnery. Astro is one of the top frontend frameworks right now and there are public blogs and docs saying Deno supports it but it doesn't really if it's 2 major versions behind. I understand there are lots of tasks and issues to prioritize but it feels like Deno will either live or die by its ability to interop with popular frameworks. I like Fresh but I can't use it exclusively for all of my projects atm. I don't think I'm alone in that situation either.
Kevin Whinnery
Kevin Whinneryโ€ข5mo ago
Very fair - I will take a fresh look this week. And FWIW the team also agrees, Node.js framework support is going to be a major theme for us this year.
jaydanurwin
jaydanurwinโ€ข5mo ago
That's great to hear! I'm definitely bullish on Deno taking some ground this year and I'm happy to help however I can. Keep up the great work!
๐•’๐•ฃ๐•ค๐•™
cant call it two versions behind if it was never released ๐Ÿง 
toybreaker
toybreakerโ€ข4mo ago
It would be great to have this issue solved, and the ASTRO DENO adapter updated, cos otherwise many Astro users will have to drop Deno and use Node, which would be a real bummer...
Nik
Nikโ€ข4mo ago
Any news on this front? There's an open PR in the deno-astro-adapter repo for 4.0 support (https://github.com/denoland/deno-astro-adapter/pull/11) and the author is willing to do more testing/work to get the changes merged. How can this be moved forward?