Deno•3y ago

Fresh migrating from serveTls

In my

main.ts

main.ts

file for Fresh I have some code I borrowed from source a few minor versions ago to serve HTTPS content when running on localhost. It looks like so

/// <reference no-default-lib="true" />
/// <reference lib="dom" />
/// <reference lib="dom.iterable" />
/// <reference lib="dom.asynciterable" />
/// <reference lib="deno.ns" />

import { ServerContext, start } from '$fresh/server.ts'
import { serveTls } from '$std/http/server.ts'
import manifest from './fresh.gen.ts'
import config from './fresh.config.ts'

const self = Deno.env.get('SELF_URL')

const servePlainHttp = self !== 'https://localhost:8000' ||
  Deno.env.get('SERVE_HTTP')

if (servePlainHttp) {
  await start(manifest, config)
} else {
  const ctx = await ServerContext.fromManifest(manifest, config)
  // deno-lint-ignore no-explicit-any
  await serveTls(ctx.handler() as any, {
    ...config,
    certFile: './local-certs/localhost.crt',
    keyFile: './local-certs/localhost.key',
  })
}

/// <reference no-default-lib="true" />
/// <reference lib="dom" />
/// <reference lib="dom.iterable" />
/// <reference lib="dom.asynciterable" />
/// <reference lib="deno.ns" />

import { ServerContext, start } from '$fresh/server.ts'
import { serveTls } from '$std/http/server.ts'
import manifest from './fresh.gen.ts'
import config from './fresh.config.ts'

const self = Deno.env.get('SELF_URL')

const servePlainHttp = self !== 'https://localhost:8000' ||
  Deno.env.get('SERVE_HTTP')

if (servePlainHttp) {
  await start(manifest, config)
} else {
  const ctx = await ServerContext.fromManifest(manifest, config)
  // deno-lint-ignore no-explicit-any
  await serveTls(ctx.handler() as any, {
    ...config,
    certFile: './local-certs/localhost.crt',
    keyFile: './local-certs/localhost.key',
  })
}

This is working, but

serveTls

serveTls

is marked deprecated in favor of

Deno.serve

Deno.serve

. However,

Deno.serve

Deno.serve

takes a single handler argument, not a handler and a config.

How might I go about migrating to

Deno.serve

Deno.serve

here? Thanks!

Deno AI Helper•12/8/23, 6:59 PM

I wasn't able to find the answer to your question in the official Deno documentation. However, based on the code snippet you've provided, I can offer some general advice.

The

serveTls

serveTls

function is indeed deprecated, and you should now use

Deno.serve

Deno.serve

to create a TLS server. The

Deno.serve

Deno.serve

function has a different API compared to

serveTls

serveTls

. To use

Deno.serve

Deno.serve

with TLS, you would need to pass the TLS options within the options object, like so:

Please note that the above code is a general example and not based on the Deno documentation. You should double-check the accuracy of this advice and consult the latest Deno API documentation or other resources for the most up-to-date information on using

Deno.serve

Deno.serve

with TLS.

In your specific case, you would need to adapt the and its handler to work with

Deno.serve

Deno.serve

. The should provide a handler function that you can pass directly to

Deno.serve

Deno.serve

. If the 's handler method returns a function compatible with

Deno.serve

Deno.serve

, you can use it like this:

Again, please verify this with the current Deno APIs and the Fresh framework documentation to ensure

Deno AI Helper•12/8/23, 6:59 PM

compatibility.

Helpful Links:
Writing tests | Fresh docs
TCP sockets and TLS | Deno Docs
Deno 1.20 Release Notes
Deno 1.17 Release Notes

marvinh.•12/8/23, 7:09 PM

@rabbit_rabbit The way

Deno.serve

Deno.serve

works is that it will serve via HTTPS when you give it a cert + key and won't if you don't. Since Fresh uses

Deno.serve

Deno.serve

already under the hood, you can simplify your code to something like this:

rabbit_rabbitOP•12/8/23, 7:40 PM

Thanks @marvinh. ! I tried that and it's still serving HTTP. For a cleaner test to ensure it's not an issue with environment variables I cleared some of the other stuff, so here's my attempt

where I see