jcayzac
jcayzac11mo ago

deno.jsonc "unstable" format?

I added this entry to my deno.jsonc:
"unstable": [
"broadcast-channel",
"ffi",
"fs",
"kv",
"net",
"http",
"worker-options",
"cron"
],
"unstable": [
"broadcast-channel",
"ffi",
"fs",
"kv",
"net",
"http",
"worker-options",
"cron"
],
…and stopped passing --unstable to the CLI, but now I'm getting errors:
error: ReferenceError: BroadcastChannel is not defined
error: ReferenceError: BroadcastChannel is not defined
What's the proper syntax? The schema only has:
"unstable": {
"type": "array",
"description": "List of unstable features to enable.",
"items": {
"type": "string"
}
}
"unstable": {
"type": "array",
"description": "List of unstable features to enable.",
"items": {
"type": "string"
}
}
…and I couldn't figure what the values are expected to be from reading the source code either. The feature name is correct (see screenshot), but that doesn't seem to work.
No description
6 Replies
jcayzac
jcayzac11mo ago
@bartlomieju is that a bug? This should work acording to the code I'm reading in the feature checker right now. Oh wow even --unstable-broadcast-channel passed to the CLI doesn't work 😮 Well, I'll just revert to passing --unstable everywhere then…
crowlKats
crowlKats11mo ago
@jcayzac could you oen an issue?
jcayzac
jcayzac11mo ago
GitHub
Granular unstable feature flags appear ignored · Issue #21434 · den...
Version: Deno 1.38.3 I added this entry to my deno.jsonc: "unstable": [ "broadcast-channel", "ffi", "fs", "kv", "net", "http", ...
bartlomieju
bartlomieju11mo ago
That seems like a bug. Thanks for reporting
jcayzac
jcayzac11mo ago
@bartlomieju @crowlKats I think I fixed https://github.com/denoland/deno/pull/21466, if you have time to review it
bartlomieju
bartlomieju11mo ago
Thanks!