Deno•3y ago

Issues with Crypto Subtle Digest ext:deno_crypto/00_crypto.js

Currently we are using

deno_core v0.200.0

deno_core v0.200.0

deno_runtime v0.123.0

deno_runtime v0.123.0

when attempting to invoke

crypto.subtle.digest

crypto.subtle.digest

the following error is reported

SHA-256 TypeError: Error parsing args at position 1: serde_v8 error: invalid type; expected: object, got: string

SHA-256 TypeError: Error parsing args at position 1: serde_v8 error: invalid type; expected: object, got: string

example for reproduction

async function main() {
  const encoder = new TextEncoder();
  const data = encoder.encode('Hello, World!');
  const hashed = await crypto.subtle.digest('SHA-256', data);
  console.log(new Uint8Array(hashed));
}

async function main() {
  const encoder = new TextEncoder();
  const data = encoder.encode('Hello, World!');
  const hashed = await crypto.subtle.digest('SHA-256', data);
  console.log(new Uint8Array(hashed));
}

According to the api docs either a string or enum should be supported as the first param.

ioB•9/30/23, 4:11 PM

I can't reproduce this, your code runs fine for me. What does

data

data

contain? Could you log it and find out?

beanOP•9/30/23, 4:19 PM

It contains UTF8 encoded but the error happens on attempting to deserialize to a enumeration type. the error looks to be around type conversion. We also tried turning to but it also errors.

ioB•9/30/23, 4:24 PM

I could be wrong, but me reading this error interprets it as data being the issue (). Position 0 in my experience is the first input.

Any reason why your versions of deno_core and deno_runtime are out of date?

beanOP•9/30/23, 4:25 PM

But its prefixed with so doesnt that indicate its an issue with the first parameter specifying the algo?

ioB•9/30/23, 4:28 PM

Not sure, good question. From a google search it does seem that is the second argument.

beanOP•9/30/23, 4:30 PM

returns a

Uint8Array

Uint8Array

so Im skeptical that a

Uint8Array

Uint8Array

can be coerced to a

ioB•9/30/23, 4:32 PM

Hold on, how do you even have with just and ?

ioB•9/30/23, 4:33 PM

You'd need to have for that (or have implemented it yourself)

beanOP•9/30/23, 4:39 PM

We do use deno_web but its a modified version we have not modified be text encoding bindings nor bindings for the cryptp api's understandable if this is outside support scope.

ioB•9/30/23, 4:40 PM

Are you able to share a reproduction of this issue? I'd love to poke around. I'm assuming you all also have a vendored version of ?

beanOP•9/30/23, 4:47 PM

no modified version of which is why this is a bit concerning. unfortunately i cannot give you a way to reproduce that can audit the behavior directly as its a remote execution environment where you wont have full log context.
we just use whats included in / and bind through our vendored bindings.

beanOP•9/30/23, 4:47 PM

but knowning that you cannot reproduce using non vendored packages is interesting. May i ask how you are testing the above code example?

ioB•9/30/23, 4:52 PM

I’m just running it in an unmodified deno build

ioB•9/30/23, 4:53 PM

Which uses the same crates as you describe, though more up to date

beanOP•9/30/23, 4:56 PM

If anyone has more information on the error report that could also be helpful, from the looks of the logging structure it seems to be a type error with the first param but now not totally sure.

beanOP•9/30/23, 4:57 PM

If anyone is able to run the source above through a env built from the exact package versions would help in our confidence in if its a bug in the op bindings or something on our end.

mmastrac•9/30/23, 9:42 PM

Note that we've been porting ops to the new op2 system over the last month and there's some pretty strict lockstep requirements between deno_core and extensions (ie: what we release is supported) due to the pretty massive flux.