Deno•3y ago

Node-API related segmentation fault

Any idea what could be causing this crash? I'm using Node-API and the same module is working fine in Node.js. Can't figure out the exact part causing this to create a reproducible example

djOP•7/26/23, 4:28 PM

cc @littledivy any idea?

djOP•7/26/23, 4:32 PM

so it comes down to this specific part. Let me check what could be causing this in native land

djOP•7/26/23, 4:53 PM

So the error comes down to

djOP•7/26/23, 4:53 PM

seems that finalizer cb being null is not handled correctly in deno

divy•7/27/23, 5:41 AM

oh huh

divy•7/27/23, 5:41 AM

whats being finalized?

djOP•7/27/23, 7:59 AM

I created an external with no finalizer callback (nullptr) and

deno just treats it as normal c callback and goes ahead to call it sometime
node will check if its null then its not called

AapoAlas•7/27/23, 8:13 AM

You never know if someone has placed a function at memory slot 0... (Apparently in some architectures it is a valid memory address.)

AAapoAlas You never know if someone has placed a function at memory slot 0... (Apparently ...

djOP•7/28/23, 7:32 AM

that’s probably a case to not worry about

in standard conforming C/C++ implementations, I guess it is possible to reliably set a function pointer to null.

AapoAlas•7/28/23, 7:33 AM

Yeah