Deno•3y ago

Allow-net not applying to npm: imports ?

Hi,
Running the below does not ask me for a permission to access github.com.

import axios from "npm:axios"

await axios.get('https://github.com')
  .then(function (response) {
    // handle success
    console.log(response);
  }).catch(err => {
    console.log(err)
  })

import axios from "npm:axios"

await axios.get('https://github.com')
  .then(function (response) {
    // handle success
    console.log(response);
  }).catch(err => {
    console.log(err)
  })

The same occur if I use for example

npm:@aws-sdk/client-s3

npm:@aws-sdk/client-s3

and try to access a bucket or using

npm:node-fetch

npm:node-fetch

.
No net access is requested.

Does

allow-net

allow-net

not apply to modules using

npm:

npm:

specifier ?
Is there a way to enforce any npm import to request for net access ?

deno version is 1.34.0
thanks

AapoAlas•5/28/23, 12:28 PM

Hmm, I do not think this should be the case but I seem to see the same behaviour.

sylcOP•5/28/23, 12:47 PM

@aapoalas thanks for confirming. It seem also a bug to me but i wasn't sure if i missed something. Should i open an issue ?

AapoAlas•5/28/23, 12:48 PM

Yeah, I think so.

sylcOP•5/28/23, 1:03 PM

I raised https://github.com/denoland/deno/issues/19301 .

GitHub

npm: imports not needing allow-net to make request · Issue #19301 ·...

Hi, Running the below does not ask me for an allow-net permission to access github.com. #!/usr/bin/env -S deno run --allow-read --allow-env import axios from "npm:axios" await axios.get(&...

bartlomieju•5/28/23, 1:44 PM

This is already fixed on

main

main

, I will release it tomorrow

AapoAlas•5/28/23, 1:45 PM

I had somehow missed this prior, sorry.