177177177•3y ago

About performance

if a function takes only one paramater and i pass unnecessary additional parameters would it affect the performance of just the function part of the code?

function echo(sentence) {
  console.log(sentence)
}

echo('hello')

echo('hello', 'bye', 'okay')

function echo(sentence) {
  console.log(sentence)
}

echo('hello')

echo('hello', 'bye', 'okay')

this is what im caonfused abt i have a object, every value is a function that takes the same parameter payload except only one value that takes an additional second parameter args i want to know which way from these two would perform better

const handler = {
  READY: (payload, args) => {},
  GUILD_CREATE: (payload) => {},
  MESSAGE_CREATE: (payload) => {}.
  // ...about 30 more
}


// should i do this
handler[eventName](payload, args)

// or this
if (eventName === 'READY') handler[eventName](payload, args)
else handler[eventName](payload)

const handler = {
  READY: (payload, args) => {},
  GUILD_CREATE: (payload) => {},
  MESSAGE_CREATE: (payload) => {}.
  // ...about 30 more
}


// should i do this
handler[eventName](payload, args)

// or this
if (eventName === 'READY') handler[eventName](payload, args)
else handler[eventName](payload)

4 Replies

177177177OP•3y ago

sorry for not using typescript types, i asked the same question in a javascript server, i copy pasted here too

AapoAlas•3y ago

IIRC It does have some effect, yes, but nothing particularly horrible. I expect the latter might be better simply because less parameters means less polymorphism.

Bubbles•3y ago

I believe more args than expected can cause deopts if you are inconsistent with the amount of args passed to that function

function a() {}

function a() {}

If I keep passing 2 args to function a it shouldn't deopt where-as if I later pass 1 it might deopt

177177177OP•3y ago

i see tyvm!

About performance

Did you find this page helpful?